Re: savecore(8) increments /var/crash/bounds on each boot

On Tue, 14 Jun 2005, 12:08-0700, David O'Brien wrote:

> On Tue, Jun 14, 2005 at 10:49:44PM +0400, Maxim Konovalov wrote:
> > On Tue, 14 Jun 2005, 01:20-0700, David O'Brien wrote:
> >
> > > On Mon, Jun 13, 2005 at 03:23:08PM -0400, Ed Maste wrote:
> > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE
> > > > savecore increments the number in /var/crash/bounds on each boot,
> > > > regardless of whether it rebooted due to panic or was a clean shutdown.
> > > > Is this the desired behaviour or an unintentional side effect?
> > >
> > > It is an unintentional side affect.  If I wasn't constantly experiencing
> > > kernel landminds every time I sit down to do major FreeBSD, I would have
> > > gotten to this issue.
> >
> > I am going to ask re_at_ for permission to commit the fix if nobody beats
> > me.
>
> Are you sure its correct?  Have you tested it with say bounds != 0 and a
> few core dumps in /var/crash?

No problems so far:

qemu6# ls -l /var/crash
total 336080
-rw-r--r--  1 root  wheel          3 Jun 14 20:02 bounds
-rw-------  1 root  wheel        426 Jun 14 19:22 info.10
-rw-------  1 root  wheel        426 Jun 14 19:31 info.11
-rw-------  1 root  wheel        425 Jun 14 19:49 info.12
-rw-------  1 root  wheel        426 Jun 14 19:57 info.13
-rw-------  1 root  wheel        462 Jun 14 20:02 info.14
-rw-------  1 root  wheel        424 Jun 14 17:44 info.7
-rw-r--r--  1 root  wheel          5 May  8 07:05 minfree
-rw-------  1 root  wheel  134217728 Jun 14 19:23 vmcore.10
-rw-------  1 root  wheel  134217728 Jun 14 19:31 vmcore.11
-rw-------  1 root  wheel  134217728 Jun 14 19:50 vmcore.12
-rw-------  1 root  wheel  134217728 Jun 14 19:58 vmcore.13
-rw-------  1 root  wheel  134217728 Jun 14 20:03 vmcore.14
-rw-------  1 root  wheel  134217728 Jun 14 17:45 vmcore.7

qemu6# cat /var/crash/bounds
15

-- 
Maxim Konovalov