Re: savecore(8) increments /var/crash/bounds on each boot

On Wed, Jun 15, 2005 at 12:10:05AM +0400, Maxim Konovalov wrote:
> On Tue, 14 Jun 2005, 12:08-0700, David O'Brien wrote:
> 
> > On Tue, Jun 14, 2005 at 10:49:44PM +0400, Maxim Konovalov wrote:
> > > On Tue, 14 Jun 2005, 01:20-0700, David O'Brien wrote:
> > >
> > > > On Mon, Jun 13, 2005 at 03:23:08PM -0400, Ed Maste wrote:
> > > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE
> > > > > savecore increments the number in /var/crash/bounds on each boot,
> > > > > regardless of whether it rebooted due to panic or was a clean shutdown.
> > > > > Is this the desired behaviour or an unintentional side effect?
> > > >
> > > > It is an unintentional side affect.  If I wasn't constantly experiencing
> > > > kernel landminds every time I sit down to do major FreeBSD, I would have
> > > > gotten to this issue.
> > >
> > > I am going to ask re_at_ for permission to commit the fix if nobody beats
> > > me.
> >
> > Are you sure its correct?  Have you tested it with say bounds != 0 and a
> > few core dumps in /var/crash?
> 
> No problems so far:

Do you understand the fix?  How does lying in printheader() fix anything?
Moving the call to getbounds() back to the original location is the "fix"
but then it negates -vv.  We shouldn't lie in printheader().

-- 
-- David  (obrien_at_FreeBSD.org)