Re: Acquiring lockmgr lock "ufs" with non-sleepable locks

Hello Suleiman,

Suleiman Souhlal wrote:

>>> This was introduced by my commit to take out the various kqueue   
>>> operations outside of ufs. It is because we are trying to lock  the  
>>> vnode while holding the knlist mutex. I'll work on a fix on   
>>> wednesday, as I'll unfortunately be a bit busy until then. I hope   
>>> this won't cause you any inconvenience.
>>>
>>
>> Is the below the same ?
> 
> 
> Yes.
> 
>> No, I did not try the follow-up patch yet.
> 
> 
> The patch should fix it. I'll commit it as soon as I get approval.

It did :) Thanks. The tail -f file works now.

Though, I took the latest diff from your site 
(knlist_locking-20050629-2.diff) and had to add the thing below, you 
forgot a NULL in knlist_init.

Regards,
Andreas

(p.s: patch hand edited)

Index: src/sys/cam/scsi/scsi_target.c
===================================================================
--- src/sys/cam/scsi/scsi_target.c	(revision 187)
+++ src/sys/cam/scsi/scsi_target.c	(working copy)
_at__at_ -196,7 +196,7 _at__at_
  	TAILQ_INIT(&softc->work_queue);
  	TAILQ_INIT(&softc->abort_queue);
  	TAILQ_INIT(&softc->user_ccb_queue);
-	knlist_init(&softc->read_select.si_note, &softc->mtx);
+	knlist_init(&softc->read_select.si_note, &softc->mtx, NULL, NULL, NULL);

  	return (0);
  }