IPFILTER Branch [was: Re: [current tinderbox] failure on powerpc/powerpc]

From: Peter Schultz <pmes_at_bis.midco.net>
Date: Sat, 7 May 2005 10:30:55 -0500
On May 6, 2005, at 1:04 PM, Max Laier wrote:
> On Tuesday 03 May 2005 02:10, Peter Grehan wrote:
>>   I've sent mail to Darren about this: it's a PPC-only (well,  
>> maybe ARM
>> as well) default-unsigned-char problem. For those that want to
>> buildworld appended is the patch I'm using.
>>
>> later,
>>
>> Peter.
>>
>> RCS file: /home/ncvs/src/contrib/ipfilter/tools/ipmon.c,v
>> retrieving revision 1.2
>> diff -u -r1.2 ipmon.c
>> --- ipmon.c     25 Apr 2005 18:20:15 -0000      1.2
>> +++ ipmon.c     1 May 2005 08:42:53 -0000
>> _at__at_ -1024,7 +1024,7 _at__at_
>>          (void) sprintf(t, "%*.*s%u", len, len, ipf->fl_ifname,
>> ipf->fl_unit);
>>          t += strlen(t);
>>   #endif
>> -#ifdef __sgi
>> +#if (defined(__sgi) || defined(__powerpc__))
>>          if ((ipf->fl_group[0] == 255) && (ipf->fl_group[1] == '\0'))
>>   #else
>>          if ((ipf->fl_group[0] == -1) && (ipf->fl_group[1] == '\0'))
>>
>
> Just saw your mail now. Darren has had enough time to veto against  
> it.  Please
> go ahead, fix the build and shut up the tinderbox.  Thanks!
>

Darren is on holiday, so you will not be getting a veto anytime soon.

As an aside, Darren is so notorious for breaking the build, I don't  
know why anyone bothers complaining anymore.  I'm beginning to think  
he does it just to get under people's skin.  Either take away his  
privileges or accept that he will be breaking the build.  Maybe there  
should be an IPFILTER branch where he can drop his bombs?
Received on Sat May 07 2005 - 13:30:59 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:34 UTC