Hi, I've committed to correct type of ai_addrlen member of struct addrinfo and n_net member of struct netent. Though it affects to 64 bit arch, I believe it doesn't break ABI backward comatibility. I'll remove padding for ABI backward comatibility after 2 weeks. When padding is removed, ABI backward comatibility will be lost on 64 bit arch. Sincerely,
attached mail follows:
ume 2005-05-15 20:15:15 UTC FreeBSD src repository Modified files: include netdb.h lib/libc/net getaddrinfo.c getnetbydns.c getnetbyht.c getnetbynis.c getnetnamadr.c netdb_private.h Log: - The ai_addrlen of a struct addrinfo used to be a size_t, per RFC 2553. In XNS5.2, and subsequently in POSIX-2001 and RFC 3493, it was changed to a socklen_t. And, the n_net of a struct netent used to be an unsigned long integer. In XNS5, and subsequently in POSIX-2001, it was changed to an uint32_t. To accomodate for this while preserving ABI compatibility with the old interface, we need to prepend or append 32 bits of padding, depending on the (LP64) architecture's endianness. - Correct 1st argument of getnetbyaddr() to uint32_t on 32 bit arch. Stay as is on 64 bit arch for ABI backward compatibility for now. Reviewed by: das, peter MFC after: 2 weeks Revision Changes Path 1.36 +46 -5 src/include/netdb.h 1.69 +4 -1 src/lib/libc/net/getaddrinfo.c 1.30 +12 -8 src/lib/libc/net/getnetbydns.c 1.15 +5 -2 src/lib/libc/net/getnetbyht.c 1.18 +7 -4 src/lib/libc/net/getnetbynis.c 1.20 +8 -3 src/lib/libc/net/getnetnamadr.c 1.9 +1 -7 src/lib/libc/net/netdb_private.h -- Hajimu UMEMOTO _at_ Internet Mutual Aid Society Yokohama, Japan ume_at_mahoroba.org ume_at_{,jp.}FreeBSD.org http://www.imasy.org/~ume/Received on Sun May 15 2005 - 18:37:39 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:34 UTC