Re: [PATCH] Locking fixes for tl(4)

On Mon, 2005-09-05 at 00:01 +0100, Gavin Atkinson wrote:
> On Sun, 4 Sep 2005, Gavin Atkinson wrote:
> > On Wed, 31 Aug 2005, John Baldwin wrote:
> >
> >> Patch fixes locking for tl(4) and marks it MPSAFE.  Please test, thanks!
> >> 
> >> http://www.FreeBSD.org/~jhb/patches/tl_locking.patch
> >
> > Doesn't work, I'm afraid.  Panic on attach:
> 
> ... because tl_hardreset() is called before sc->tl_ifp is allocated.  I'm 
> recompiling now, having moved the if_alloc and related code to before the 
> first hardreset() call.

The attached patch has survived pan average amount of network activity
overnight.  It's basically your original patch, but with a slight
rearrangement in tl_attach() to move the if_alloc() call earlier.

Gavin