On Monday 05 September 2005 08:07 am, Gavin Atkinson wrote: > On Mon, 2005-09-05 at 00:01 +0100, Gavin Atkinson wrote: > > On Sun, 4 Sep 2005, Gavin Atkinson wrote: > > > On Wed, 31 Aug 2005, John Baldwin wrote: > > >> Patch fixes locking for tl(4) and marks it MPSAFE. Please test, > > >> thanks! > > >> > > >> http://www.FreeBSD.org/~jhb/patches/tl_locking.patch > > > > > > Doesn't work, I'm afraid. Panic on attach: > > > > ... because tl_hardreset() is called before sc->tl_ifp is allocated. I'm > > recompiling now, having moved the if_alloc and related code to before the > > first hardreset() call. > > The attached patch has survived pan average amount of network activity > overnight. It's basically your original patch, but with a slight > rearrangement in tl_attach() to move the if_alloc() call earlier. I'll probably just leave the conditional asserts out altogether as that's what I've done with all the other drivers I've committed and leave if_alloc() where it is. Thanks for testing! -- John Baldwin <jhb_at_FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.orgReceived on Wed Sep 14 2005 - 20:01:28 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:43 UTC