Re: top(1) stopped working on -current

On 2006-04-27 17:13, Giorgos Keramidas <keramida_at_FreeBSD.org> wrote:
> # --- src/sys/kern/sched_4bsd.c   (revision 19)
> # +++ src/sys/kern/sched_4bsd.c   (working copy)
> # _at__at_ -31,11 +31,11 _at__at_
> #   * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> #   * SUCH DAMAGE.
> #   */
> #
> #  #include <sys/cdefs.h>
> # -__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.78 2006/04/17 18:20:37 jhb Exp $");
> # +__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.79 2006/04/26 19:42:38 jmg Exp $");
> #
> # [...]
>
> The main problems with this change are:
>
>     1) It doesn't update consumers of the kern.ccpu sysctl that we
>        already have in the tree (i.e. top(1) which you saw breaking).

FWIW, the current consumers of `kern.ccpu' are:

giorgos_at_gothmog:~/ws/bsd/src$ fgrep -r kern.ccpu .
./bin/ps/nlist.c:       if (sysctlbyname("kern.ccpu", &ccpu, &oldlen, NULL, 0) == -1)
./usr.bin/systat/pigs.c:        err = sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0);
./usr.bin/systat/pigs.c:                perror("kern.ccpu");
./usr.bin/top/machine.c:        GETSYSCTL("kern.ccpu", ccpu);
./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: if (sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0) == -1) {
./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c:         syslog(LOG_ERR, "hrProcessorTable: sysctl(kern.ccpu) failed");
giorgos_at_gothmog:~/ws/bsd/src$