Re: [head tinderbox] failure on amd64/amd64

On Sat, 5 Aug 2006, FreeBSD Tinderbox wrote:

FT> mkdep -f .depend -a    -DRDUMP -DRESCUE /src/sbin/dump/itime.c /src/sbin/dump/main.c /src/sbin/dump/optr.c /src/sbin/dump/dumprmt.c /src/sbin/dump/tape.c /src/sbin/dump/traverse.c /src/sbin/dump/unctime.c /src/sbin/dump/cache.c
FT> echo dump: /obj/amd64/src/tmp/usr/lib/libc.a  >> .depend
FT> cc -O2 -pipe  -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/itime.c
FT> cc -O2 -pipe  -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/main.c
FT> cc -O2 -pipe  -DRDUMP -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /src/sbin/dump/optr.c
FT> /src/sbin/dump/optr.c: In function `timeest':
FT> /src/sbin/dump/optr.c:214: warning: field precision is not type int (arg 7)

It seems at least on amd64 size_t (strlen() result) is not int.

Maybe the following quick fix?

Index: optr.c
===================================================================
RCS file: /home/ncvs/src/sbin/dump/optr.c,v
retrieving revision 1.33
diff -u -r1.33 optr.c
--- optr.c      5 Aug 2006 12:50:38 -0000       1.33
+++ optr.c      5 Aug 2006 18:07:34 -0000
_at__at_ -211,7 +211,7 _at__at_
                tdone_str = ctime(&tdone);
                setproctitle(
                    "%s: pass %d: %3.2f%% done, finished in %d:%02d at %.*s",
-                   disk, passno, percent, hours, mins, strlen(tdone_str) - 1, tdone_str);
+                   disk, passno, percent, hours, mins, (int)(strlen(tdone_str) - 1), tdone_str);
                if (tnow >= tschedule) {
                        tschedule = tnow + 300;
                        if (blockswritten < 500)


Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck_at_rinet.ru ***
------------------------------------------------------------------------