Re: 802.1Q vlan performance. [PATCH]

From: John Baldwin <jhb_at_freebsd.org>
Date: Fri, 25 Aug 2006 13:05:30 -0400
On Friday 25 August 2006 10:56, Gleb Smirnoff wrote:
> On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin wrote:
> J> > I> +++ /usr/src/sys/conf/NOTES       25 Aug 2006 10:03:18 -0000
> J> > I> _at__at_ -646,6 +646,7 _at__at_
> J> > I>  #
> J> > I>  device         ether                   #Generic Ethernet
> J> > I>  device         vlan                    #VLAN support (needs miibus)
> J> > I> +options                VLAN_ARRAY              #Lookup table for 
trunk interface
> J> > I>  device         wlan                    #802.11 support
> J> > I>  device         wlan_wep                #802.11 WEP support
> J> > I>  device         wlan_ccmp               #802.11 CCMP support
> J> > 
> J> > I'd prefer not to put it into NOTES. When enabled, less code will
> J> > be covered by LINT.
> J> 
> J> Bah, GENERIC will cover it then.  All options should be in NOTES.  If
> J> an option removes code and it's enabled in GENERIC, then you should put
> J> it in NOTES but comment it out.
> 
> But "device vlan" isn't in GENERIC.

Then put the option in and comment it out.  NOTES serves 2 purposes: 1 is to 
provide the basis for LINT, the second is to document the various options and 
devices.

-- 
John Baldwin
Received on Fri Aug 25 2006 - 15:57:17 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:59 UTC