Re: LOR when booting CURRENT (ip_divert.c, PFil hook read/write mutex) [#181]

From: Christian S.J. Peron <csjp_at_FreeBSD.org>
Date: Mon, 31 Jul 2006 15:46:02 -0500
Robert Huff wrote:
> Yar Tikhiy writes:
>
>   
>>  FWIW, the LOR still is there.  I was seeing it yesterday while
>>  fiddling with the ipfw and natd rc.d scripts.
>>  
>>  lock order reversal:
>>   1st 0xc1a36090 inp (divinp) _at_ /usr/src/sys/modules/ipdivert/../../netinet/ip_divert.c:350
>>   2nd 0xc0a51918 PFil hook read/write mutex (PFil hook read/write mutex) _at_ /usr/src/sys/net/pfil.c:73
>>     
>
> 	For the record, I'm (still) getting this also.
>
>
> 				Robert Huff
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
>
>   

This appears to be similar to the LOR associated with IPFW and ucred 
based rules, I think. Although this is a lock order reversal and it 
probably isn't a false positive, it should be reasonably harmless, 
because the pfil hook lock is a reader lock, thus different threads can 
acquire it (at this point) con-currently, presumably preventing a dead 
lock from actually occurring here.

iirc witness it not aware of the reader/writer semantics, so it makes 
sense that it will be dropping a warning here. But I can look at this in 
further detail when I get a bit of time.

-- 
Christian S.J. Peron
csjp_at_FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team
Received on Mon Jul 31 2006 - 18:46:03 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:58 UTC