Re: exca(4) caused panic

From: M. Warner Losh <imp_at_bsdimp.com>
Date: Thu, 09 Mar 2006 13:16:00 -0700 (MST)
In message: <20060309084500.44e5b8ae.ai_at_bmc.brk.ru>
            Artemiev Igor <ai_at_bmc.brk.ru> writes:
: 
: With 1.23 revision /sys/dev/exca/exca.c my notebook going to the panic,
: when an pccard inserted. That patch fixed this problem:
: 
: --- sys/dev/exca/exca.c.orig Thu Mar  9 08:26:13 2006
: +++ sys/dev/exca/exca.c  Thu Mar  9 08:26:44 2006
: _at__at_ -179,11 +179,11 _at__at_
:     struct mem_map_index_st *map;
:     struct pccard_mem_handle *mem;
:     uint32_t offset;
: -   int mem8 = (mem->kind == PCCARD_A_MEM_ATTR);
: -   mem8 = 1;
: +   int mem8; 
: 
:     map = &mem_map_index[win];
:     mem = &sc->mem[win];
: +   mem8 = (mem->kind == PCCARD_A_MEM_ATTR);
:     offset = ((mem->cardaddr >> EXCA_CARDMEM_ADDRX_SHIFT) -
:       (mem->addr >> EXCA_SYSMEM_ADDRX_SHIFT)) & 0x3fff;
:     exca_putb(sc, map->sysmem_start_lsb,
: 

I wonder why notebook doesn't panic.  None-the-less, I've committed a
fix for this to head.  Thanks for the catch.

Warner
Received on Thu Mar 09 2006 - 19:16:15 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:53 UTC