if_ndis.c breakage in rev 1.114

From: Krzysztof Jędruczyk <beaker_at_hot.pl>
Date: Sun, 12 Mar 2006 21:01:03 +0100
Hi,

I have performed upgrade on my IBM T41 from RELENG_5_3 to RELENG_6 today 
(I've been delaying that upgrade for some time...). Went moreless 
smooth, but ndis0 stopped working (panic when trying to assiociate with 
access point).

Long story made short: this patch makes ndis working again for me (I'm 
sending this message from the upgraded laptop, which proves my point 
well enough I guess ;)

--- /usr/src/sys/dev/if_ndis/if_ndis.c~ Fri Dec 16 18:33:47 2005
+++ /usr/src/sys/dev/if_ndis/if_ndis.c  Sun Mar 12 20:20:11 2006
_at__at_ -2509,7 +2509,7 _at__at_
                 return(ENOENT);
         }

-       len = 4;
+       len = 0;
         error = ndis_get_info(sc, OID_802_11_BSSID_LIST, NULL, &len);
         if (error != ENOSPC)
                 len = 65536;


I think I have spotted obvious commit mistake, since log message for 
rev. 1.114 is clear about what is done here ("if using a length of 0 
yields anything besides the expected error case, we arbitrarily assume a 
length of 64K").

-- 
   Best regards,
     Krzysztof Jędruczyk
Received on Sun Mar 12 2006 - 19:00:56 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:53 UTC