Re: FreeBSD-SA-06:14.fpu

On Friday 19 May 2006 09:10, Rostislav Krasny wrote:

> Ok. What should I do before adding the above #ifdef's? Is it enough to
> change following files only?
>
> src/sys/conf/options
I think they are sys/conf/options.i386 and sys/conf/options.amd64

> src/sys/i386/conf/GENERIC
> src/sys/i386/conf/NOTES
> src/sys/i386/conf/PAE
> src/sys/i386/conf/SMP
> src/sys/amd64/conf/GENERIC
> src/sys/amd64/conf/NOTES
> src/sys/amd64/conf/SMP
>
I think modifying GENERIC and NOTES is enough.

> > but I would call it BUG_FXSAVE like Linux's select()
> > changed timeout value which only added incompatibility rather than
> > advantage.
>
> I don't know about Linux's select() but according to what I've seen on
> their "7466f9e72dac13452d871a3fb72fc7bd9c93c864" commit they use
> X86_FEATURE_FXSAVE_LEAK. What do you think about FXSAVE_LEAK instead of
> BUG_FXSAVE?

I have no objection.

David Xu