Re: Crash in accounting code: encode_long(), due to bad rusage data?

From: Diomidis Spinellis <dds_at_aueb.gr>
Date: Mon, 20 Aug 2007 13:37:50 +0300
Jeff Roberson wrote:
>> Robert Watson wrote:
>>> I recently upgraded two servers from FreeBSD 6-STABLE to FreeBSD 
>>> 7-CURRENT in anticipation of the forthcoming release.  Both of them 
>>> run with accounting enabled at all times.  When a large pine session 
>>> was exiting on one of the two boxes, I ran into the following panic:
>>>
>>> panic: encode_long: -ve value -32749
[...]
> What do you think about simply putting in a max value if we overflow?  
> We could then make a note about it in process accounting docs.  We might 
> want to fix this in rusage as well.

Encoding LONG_MAX and issuing a printf warning is I think a reasonable 
solution.  I'll be away from a broadband connection until Friday, so if 
anybody else wants to commit this, go ahead.  Otherwise I can do it over 
the coming weekend.

Diomidis Spinellis - http://www.spinellis.gr
Received on Mon Aug 20 2007 - 08:38:37 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:16 UTC