Re: Crash in accounting code: encode_long(), due to bad rusage data?

On Mon, 20 Aug 2007, Diomidis Spinellis wrote:

> Jeff Roberson wrote:
>>> Robert Watson wrote:
>>>> I recently upgraded two servers from FreeBSD 6-STABLE to FreeBSD 
>>>> 7-CURRENT in anticipation of the forthcoming release.  Both of them run 
>>>> with accounting enabled at all times.  When a large pine session was 
>>>> exiting on one of the two boxes, I ran into the following panic:
>>>> 
>>>> panic: encode_long: -ve value -32749
> [...]
>> What do you think about simply putting in a max value if we overflow?  We 
>> could then make a note about it in process accounting docs.  We might want 
>> to fix this in rusage as well.
>
> Encoding LONG_MAX and issuing a printf warning is I think a reasonable 
> solution.  I'll be away from a broadband connection until Friday, so if 
> anybody else wants to commit this, go ahead.  Otherwise I can do it over the 
> coming weekend.

I'm pretty maxed out here right now, so certainly won't get to it sooner, so 
if you don't mind doing it this weekend, that would be good.

Robert N M Watson
Computer Laboratory
University of Cambridge