Re: [PATCH] gprof's broken in 7-CURRENT

From: David O'Brien <obrien_at_freebsd.org>
Date: Tue, 4 Dec 2007 09:55:41 -0800
I'm not sure what the action item is.
This looks OK to me - do you want me to commit it to HEAD right now so we
can let it soak a little before discussing it with RE?

-- David

On Fri, Nov 30, 2007 at 03:38:27AM +0200, Giorgos Keramidas wrote:
> Please pass this through the release engineering team, Bruce Evans
> (who has the largest number of commits to the file), and our gcc
> folks (David O'Brien, and Alexander Kabaev).
> 
> If it is considered safe for RELENG_7 (what will become 7.0-RELEASE),
> then it's probably a good idea to commit it.  It looks `harmless' to me,
> but it certainly won't harm to get a proper review from much more
> experienced people (added to the Cc: list).
> 
> It would be marvellous to have non-broken profiling in 7.0.
> 
> - Giorgos
> 
> On 2007-11-30 01:38, Nikos Ntarmos <ntarmos_at_ceid.upatras.gr> wrote:
> > I couldn't wait for Garrett :) so I went on and tested your patch and
> > gprof seems to work fine for me (at least for the executables I was
> > interested in profiling anyway). This is i386 on a 7.0-BETA3 kernel and
> > 7.0-BETA1 world. What are the chances for this to be committed in time
> > for 7.0R?
> 
> On 2007-11-29 20:24, Luoqi Chen <luoqi_at_freebsd.org> wrote:
> > Garrett, would you like to try out my fix? It's actually quite simple,

-- 
-- David  (obrien_at_FreeBSD.org)
Received on Tue Dec 04 2007 - 16:55:50 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:23 UTC