Re: mount_ntfs: /dev/ad0s1: No such file or directory

On Sat, Feb 17, 2007 at 11:22:33AM -0500, Craig Rodrigues wrote:
> On Sat, Feb 17, 2007 at 03:16:29AM +0100, Olivier Houchard wrote:
> > That may be my fault.
> 
> I think your recent patch to vfs_mount.c:
> 
> cognet      2007-02-13 01:28:49 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             vfs_mount.c
>   Log:
>   Make vfs_getopts() set *error to ENOENT if the option wasn't found, so that
>   consumers don't have to check for both error and the return value (some of
>   them actually don't do it).
> 
>   MFC After:      1 week
> 
> 
> 
> exposed some bugs in the NTFS mount code.  Your patch to
> vfs_mount.c is a reasonable one, but it turns out to be an API change
> because it changes the behavior of vfs_getopts().  Did you
> audit all the file systems which use this function, and fix them
> to conform to the API change?
> 

Hi Craig,

Apparently not enough ;-)
I'm in discussion with Bruce Evans about this, he brought up valid concerns
about this change, maybe I'll revert it and check all consumers of vfs_getopts
to make sure they check the return value instead.

Cheers,

Olivier