Re: recent commits break via 8235 ata

On Tuesday 27 March 2007 10:07:42 am Giorgos Keramidas wrote:
> On 2007-03-27 15:10, Alexander Leidinger <Alexander_at_leidinger.net> wrote:
> > Quoting Giorgos Keramidas <keramida_at_ceid.upatras.gr> (from Tue, 27 Mar  
> > 2007 11:28:24 +0300):
> > 
> > >On 2007-03-26 22:04, Nate Lawson <nate_at_root.org> wrote:
> > >>Something between 2007/2/19 and 2007/3/25 breaks ata on my VIA laptop.
> > >>It boots and ad0 is not detected so it can't mount root.
> > >>
> > >>The device is:
> > >>atapci0: <VIA 8235 UDMA133 controller> port
> > >>0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 17.1 on pci0
> > >>
> > >>PCI config:
> > >>atapci0_at_pci0:17:1: class=0x01018a card=0x120a14ff chip=0x05711106
> > >>rev=0x06 hdr=0x00
> > >
> > >There are other devices which also have detection problems.  snd_ich and
> > >snd_hda are two that I know.
> > >
> > >Can you try updating to a kernel before the latest ACPI import?  We seem
> > >to be having various interesting problems with the kernel during the last
> > >10 days or so, and that's one of the major changes that went in...
> > 
> > Another reason may be the change in nexus from jhb.
> 
> Yes.  I haven't had the time to do binseach through the changes, to see
> which was the "one commit" which broke snd_hda here.

If that is the case it's because code was using rman_get_bus(handle|tag) on a 
resource that wasn't activated yet which wouldn't have worked before the 
nexus changes either.  Well, the bus tag might have been right, but the 
handle for SYS_RES_MEMORY would have been wrong.

-- 
John Baldwin