Re: [PATCH] Fancy rc startup (revisited)

On 05/11/07 08:26, Alexander Leidinger wrote:
> Quoting Eric Anderson <anderson_at_freebsd.org> (from Fri, 11 May 2007  
> 07:42:35 -0500):
> 
>> About a year ago, I posted[1] a patch to 6-STABLE that added a fancy rc
>> startup style similar to linux, with the [OK], [FAILED], etc printouts.
>>   That patch had serious bit rot and other issues, and so I've now
>> revamped it to work on -CURRENT, with a more refined usage, and
>> defaults to off.
> 
> I think it is better suited in the rc mailinglist.


Yes, I agree, but I wanted a little regular feedback first.  I'm not on 
-rc, so this was a quick first pass.


>> I'd rather stay away from a massive bikeshedding, so let me summarize:
> 
> AFAIR the outcome of the last discussion was, that it is ok as long as  
> the default is to keep the current way of displaying things (which is  
> what your patch does). So if there are no technical issues with the  
> patch, it should be ok to commit them.

That's correct, and I'm just doing the quick 'peer review' before I beg 
for a commit.  :)

>> I'd like to here feedback, and would love to see this go in to the
> 
> Do you have a screenshot? People love screenshots and you may get some  
> voices like "I want to have this!" from people which fear to install a  
> patch or from those which don't have time to patch.

Here's some kind of bad ones from a qemu session (ignore those calcru 
errors which I can't seem to get rid of):

http://www.googlebit.com/freebsd/patches/rc_fancy_screenshots/


Eric