[Fwd: Serious problem with mount(8)]

From: Joe Marcus Clarke <marcus_at_FreeBSD.org>
Date: Tue, 22 May 2007 15:22:41 -0400
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I think this email got eaten by the recent mailman problems, so I'm
resending.  Any feedback on this would be appreciated.

Joe

- -------- Original Message --------
Subject: Serious problem with mount(8)
Date: Thu, 17 May 2007 14:19:21 -0400
From: Joe Marcus Clarke <marcus_at_FreeBSD.org>
Organization: FreeBSD, Inc.
To: current_at_freebsd.org <current_at_freebsd.org>
CC: pjd_at_freebsd.org

I really don't know why I didn't notice this before, but when mount was
converted to use the pidfile(3) API three months ago, the behavior of
mount(8) changed with regard to restarting mountd.  A pidfile client
cannot use pidfile_open(3) as this will truncate the pidfile.  The
result is that mount reads in a PID of 0, and when it tries to send a
SIGHUP to this PID, it kills itself.  Consequently, this is breaking the
ports Tinderbox.

I suppose we could revert to the previous behavior, but use flopen() to
test if the file is actually locked.  Maybe something like this:

http://www.marcuscom.com/downloads/mount.c.diff

Joe



- --
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome_at_FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGU0MBb2iPiv4Uz4cRAkHlAJ9inrjwmUU8+iaFbmQ/06z6Wak2ygCeN19q
Hlqo5gpIBOdoWcjAUVMkz8c=
=gUKr
-----END PGP SIGNATURE-----
Received on Tue May 22 2007 - 17:22:31 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:10 UTC