-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dag-Erling Smørgrav wrote: > Joe Marcus Clarke <marcus_at_FreeBSD.org> writes: >> I really don't know why I didn't notice this before, but when mount was >> converted to use the pidfile(3) API three months ago, the behavior of >> mount(8) changed with regard to restarting mountd. A pidfile client >> cannot use pidfile_open(3) as this will truncate the pidfile. The >> result is that mount reads in a PID of 0, and when it tries to send a >> SIGHUP to this PID, it kills itself. Consequently, this is breaking the >> ports Tinderbox. >> >> I suppose we could revert to the previous behavior, but use flopen() to >> test if the file is actually locked. Maybe something like this: >> >> http://www.marcuscom.com/downloads/mount.c.diff > > Better yet, extend the pidfile API with a function which reads the > contents of a PID file and also checks whether it's locked. I'd be happy to do this. Is my approach with this code sound (i.e. can I simply port this to pidfile(3)), or should I take another approach? Thanks. Joe - -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome_at_FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGU07ib2iPiv4Uz4cRAro0AKCQp9xjvvozdAZnV/AKkAG+f28O2QCfUFtn Qh7BiapUrg+rRccFb9GQ0TA= =aers -----END PGP SIGNATURE-----Received on Tue May 22 2007 - 18:13:02 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:10 UTC