On Tue, May 22, 2007 at 10:05:57PM +0200, Dag-Erling Sm??rgrav wrote: > Joe Marcus Clarke <marcus_at_FreeBSD.org> writes: > > I really don't know why I didn't notice this before, but when mount was > > converted to use the pidfile(3) API three months ago, the behavior of > > mount(8) changed with regard to restarting mountd. A pidfile client > > cannot use pidfile_open(3) as this will truncate the pidfile. The > > result is that mount reads in a PID of 0, and when it tries to send a > > SIGHUP to this PID, it kills itself. Consequently, this is breaking the > > ports Tinderbox. > > > > I suppose we could revert to the previous behavior, but use flopen() to > > test if the file is actually locked. Maybe something like this: > > > > http://www.marcuscom.com/downloads/mount.c.diff > > Better yet, extend the pidfile API with a function which reads the > contents of a PID file and also checks whether it's locked. That would be useful also for pkill(1). -- Pawel Jakub Dawidek http://www.wheel.pl pjd_at_FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:10 UTC