Re: non-functional backout for review

From: Nathan Lay <nslay_at_comcast.net>
Date: Wed, 31 Oct 2007 23:22:36 -0400
Andrey Chernov wrote:
> Some people complaints that new check in __isctype() is not human readable 
> and requests for backout. Compiler gives almost identical code for old and 
> new excepting non-optimized case where non-human readable one wins. I am a 
> bit tired to change it forth and back, so ask for final consensus here.
>
> Old one
>
> return (_c < 0 || _c >= 128) ? 0 :
>
> New one (requests for backout)
>
> return (_c & ~0x7F) ? 0 :
>
>   
Why not just comment out the old version just above the new version?

Best Regards,
Nathan Lay
Received on Thu Nov 01 2007 - 02:57:41 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:20 UTC