-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Andrey V. Elsukov wrote: > Xin LI wrote: >> Thanks for the information, I'd appreciate if you would help me to test >> the attached patch against RELENG_7 (should apply to HEAD as well). > > Hi, Xin. > > This patch is not correct for me. I think we need implement a > full support for several new Marvell chips: > #define ATA_M88SE6101 0x610111ab /* ThorLite 1P */ > #define ATA_M88SE6111 0x611111ab /* ThorLite 1S/1P */ > #define ATA_M88SE6121 0x612111ab /* ThorLite 2S/1P */ > #define ATA_M88SE6122 0x612211ab /* ThorLite 2S/1P w/ flash */ > #define ATA_M88SE6141 0x614111ab /* Thor 4S/1P */ > #define ATA_M88SE6145 0x614511ab /* Thor 4S/1P */ Yes, you are correct, we need some AHCI stuff. > There is a linux driver from ASUS: > ftp://dlsvr01.asus.com/pub/ASUS/mb/socket775/P5E_WS_Professional/LinuxDrivers.zip Googl'ing did not revealed me some useful material like datasheets for this, so what we can do is probably to "guess" the meaning of the Linux driver (I have got one but that appears to be generated by some script containing a lot of redundant code and mostly "XXX not yet" comments :-/) The download from the site you mentioned is quite slow here. It's 1:00AM here so I have to go to sleep, and have the download continue. > These controllers have one PATA port and may have several SATA ports. > As i understand from the sources controller is mostly AHCI-like. It > use AHCI registers, but not fully AHCI. Also driver need some hacks > if we want to have both SATA and PATA support, because current our > ata driver uses methods from the parent atapci driver for each > channel, but we need different methods for SATA and PATA. > > I think the right way - try to fix ICH9 part of this problem and wait > until we will have a full support for the Marvell chips. Yes. Unfortunately one of the patch that attempts to address the speed mismatch was wrong due to a misread of the spec, so please don't bother to try that patcheset. BTW I have reproduced some READ_BIG issues but that's unrelated chipset, which could be some hardware problem because it is old. Do you have some more issues with ICH9 except those are mentioned in this thread? It seems that you have mentioned kern/113195 and kern/116125, according to my first glance these patches it seems that the second one contains all necessary bits in the first one (maybe some slight difference due to different KPI, though), and the risk seems to be controllable (does not seem to break previously supported chipset). I guess it might be ok to have it committed with some proper review, I will try to ping sos_at_ tomorrow morning after some careful inspect to it. Cheers, - -- Xin LI <delphij_at_delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHMDA2hcUczkLqiksRAuMQAJ9agNvjNAm4VztrKtdbM+rEPSYraQCdE2VC UOlzR0SAZ8Nl/sUZ/h6pN0g= =cx1Z -----END PGP SIGNATURE-----Received on Tue Nov 06 2007 - 08:13:58 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:21 UTC