Re: last call for L2/L3 rewrite code review

From: Kip Macy <kmacy_at_freebsd.org>
Date: Thu, 11 Dec 2008 13:38:04 -0800
I think that you're request to not monopolize the AF_INET slot is
reasonable. Do you intend to merge bms_netdev before 8 branches (I'm
guessing this coming summer)?


Cheers,
Kip

On Thu, Dec 11, 2008 at 10:18 AM, Bruce M. Simpson <bms_at_freebsd.org> wrote:
> Hi,
>
> Just skimming this I notice it uses the if_afdata[AF_INET] pointer purely
> for lltbl purposes; this clashes with the IGMPv3 code drop.
>
> Please look in the bms_netdev branch, where I introduce a 'struct ip_ifinfo'
> to make more general use of that slot. IGMPv3 needs to store per-interface
> state for AF_INET, so this slot really needs to be shared with other AF_INET
> stuff.
>
> Looks like it needs to be updated for VIMAGE also, hopefully others more
> familiar with this can help -- I am busy enough with non-programming
> activity as it is to get up to speed on this, although I have at least
> managed to print Julian's write-up...
>
> Other than that, it looks like a much needed improvement and we are all very
> grateful for our work on this.
>
> thanks
> BMS
> _______________________________________________
> freebsd-net_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe_at_freebsd.org"
>



-- 
If we desire respect for the law, we must first make the law respectable.
- Louis D. Brandeis
Received on Thu Dec 11 2008 - 20:38:06 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:38 UTC