Re: axe(4) doesn't work (patch to replace obsolete if_watchdog interface)

Norikatsu Shigemura wrote:
> Hi, wpaul.
>
> 	I got USB2.0 GbE Ether Adaptor a.k.a. PLANEX GU-1000T, but I
> 	can't use it by axe(4).  So I tried to improve axe(4) driver,
> 	but I couldn't improve it:-(.  Would you please fix this driver?
>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> ehci0: <Intel 82801FB (ICH6) USB 2.0 controller> mem 0xb0040000-0xb00403ff irq 23 at device 29.7 on pci0
> ehci0: [GIANT-LOCKED]
> ehci0: [ITHREAD]
> usb1: EHCI version 1.0
> usb1: companion controller, 2 ports each: usb0
> usb1: <Intel 82801FB (ICH6) USB 2.0 controller> on ehci0
> usb1: USB revision 2.0
> uhub1: <Intel EHCI root hub, class 9/0, rev 2.00/1.00, addr 1> on usb1
> uhub1: 2 ports with 2 removable, self powered
> axe0: <vendor 0x0b95 product 0x1780, class 255/255, rev 2.00/0.01, addr 2> on uhub1
> axe0: AX88178, bufsz 4096, boundary 512
> miibus0: <MII bus> on axe0
> ukphy0: <Generic IEEE 802.3u media interface> PHY 0 on miibus0
> ukphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseSX, 1000baseT, 1000baseT-FDX, auto
> axe0: WARNING: using obsoleted if_watchdog interface
> axe0: WARNING: using obsoleted IFF_NEEDSGIANT flag
> axe0: Ethernet address: 00:90:cc:ef:b9:f6
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> 	ISSUE:
> 	1. after ether cable connected, axe(4) doesn't link up.
> 	2. axe0 doesn't link up by 'ifconfig axe0 up', too.
> 	3. so I couldn't communicate other machines.
> 	4. I didn't know that axe(4) requires GIANT lock:-(.
>
> 	HAPPY:
> 	1. MAC Address is correct.
> 	2. I could replace obsolete if_watchdog interface.
> 	   SEE ALSO: attached patches
>   
> ------------------------------------------------------------------------

[bill doesn't deal with stuff any more so no point involving him]

I just tried my Linksys USB1000 (AX88178) on HEAD and it worked as 
expected.  There are a slew of LOR's related to the ifnet multicast code 
holding a mtx over driver work but other than that I got link after 
marking the interface up, was able to get a dhcp lease, and upstream tcp 
netperf was about what I'd expect.

Not sure there's any point chasing usb issues right now; alfred is going 
to bring in new usb code and at that point he'll be dealing with 
regressions.

    Sam