Re: tx(4) MPSAFE patch

On Monday 02 June 2008 07:10:11 pm Florian Smeets wrote:
> Florian Smeets wrote:
> > John Baldwin wrote:
> >> On Monday 02 June 2008 05:09:57 pm Florian Smeets wrote:
> >>> John Baldwin wrote:
> >>>> I have a patch to make tx(4) MPSAFE.  I do not have the hardware to 
> >>>> test 
> >> this
> >>>> however.  Unlike many of the previous patches, though, this driver 
> >>>> appears 
> >> to
> >>>> be for hardware that is not entirely ancient, so there is hopefully a 
> >> decent
> >>>> chance someone can test this.
> >>>>
> >>>> http://www.FreeBSD.org/~jhb/patches/tx.patch
> >>>>
> >>> Hi John,
> >>>
> >>> sorry does not work, do you need anything else than the backtrace? 
> >>> FWIW, this is an SMP system with 2 CPUs.
> >>
> >> Ok, I've updated the patch to fix this (and to fix a few other minor 
> >> nits with the driver).  Please refetch the patch from the URL above 
> >> and try again.  Thanks.
> >>
> > 
> > 
> > 
> > It goes on like that forever sometimes the zone varies between "16" "32" 
> > and "64". The system does not boot further, or i was just to impatient...
> > 
> 
> In fact i was too impatient, it did boot. After the last witness warning 
> these messages appear:
> 
> tx0: Ethernet address: 00:e0:29:6c:2e:47
> tx0: [ITHREAD]
> 
> tx0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
>          options=8<VLAN_MTU>
>          ether 00:e0:29:6c:2e:47
>          inet 172.30.1.100 netmask 0xffff0000 broadcast 172.30.255.255
>          media: Ethernet autoselect (100baseTX <full-duplex>)
>          status: active
> 
> And it does work
> 
> flo_at_fw-pri:~ 1  > ping 172.30.1.100
> PING 172.30.1.100 (172.30.1.100): 56 data bytes
> 64 bytes from 172.30.1.100: icmp_seq=0 ttl=64 time=1.780 ms
> 64 bytes from 172.30.1.100: icmp_seq=1 ttl=64 time=0.969 ms
> 64 bytes from 172.30.1.100: icmp_seq=2 ttl=64 time=0.974 ms

Ok, I've updated the patch again (same URL) which should fix the witness 
warnings.  I also botched the watchdog timer in the previous patch and that 
should be fixed now, too.

-- 
John Baldwin