Re: tx(4) MPSAFE patch

John Baldwin wrote:
> On Monday 02 June 2008 07:10:11 pm Florian Smeets wrote:
>> Florian Smeets wrote:
>>> John Baldwin wrote:
>>>> On Monday 02 June 2008 05:09:57 pm Florian Smeets wrote:
>>>>> John Baldwin wrote:
>>>>>> I have a patch to make tx(4) MPSAFE.  I do not have the hardware to 
>>>>>> test 
>>>> this
>>>>>> however.  Unlike many of the previous patches, though, this driver 
>>>>>> appears 
>>>> to
>>>>>> be for hardware that is not entirely ancient, so there is hopefully a 
>>>> decent
>>>>>> chance someone can test this.
>>>>>>
>>>>>> http://www.FreeBSD.org/~jhb/patches/tx.patch
>>>>>>
> 
> Ok, I've updated the patch again (same URL) which should fix the witness 
> warnings.  I also botched the watchdog timer in the previous patch and that 
> should be fixed now, too.
> 

Hi John,

still no go. Another mutex not owned panic. I'll be away until Tuesday, 
I'll be happy to test further patches than.

Cheers,
Florian

tx0: <SMC EtherPower II 10/100> port 0xc400-0xc4ff mem 
0xe7000000-0xe7000fff irq 18 at device 11.0 on pci0
miibus0: <MII bus> on tx0
acphy0: <AC101 10/100 media interface> PHY 3 on miibus0
acphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
panic: mutex tx0 not owned at /usr/src/sys/dev/tx/if_tx.c:1226
cpuid = 0
KDB: enter: panic
[thread pid 0 tid 100000 ]
Stopped at      kdb_enter+0x3a: movl    $0,kdb_why
db> where
Tracing pid 0 tid 100000 td 0xc084d300
kdb_enter(c079464d,c079464d,c079310c,c0c207cc,0,...) at kdb_enter+0x3a
panic(c079310c,c212f860,c078a020,4ca,c0c207f4,...) at panic+0x12c
_mtx_assert(c2046c34,4,c078a020,4ca,c2123900,...) at _mtx_assert+0x87
epic_miibus_mediainit(c2123900,c20d0928,c07d02cc,c2132300,c212d040,...) 
at epic_miibus_mediainit+0x37
miibus_mediainit(c2132300,c20b3128,c07d02cc,0,c2129520,...) at 
miibus_mediainit+0x4c
acphy_attach(c2132280,c2108054,c080bae4,c0796e08,80000000,...) at 
acphy_attach+0x276
device_attach(c2132280,c2132280,c0796d66,935,c2132280,...) at 
device_attach+0x36f
device_probe_and_attach(c2132280,c2132300,c0c208dc,c04e79f7,c2132300,...) 
at device_probe_and_attach+0x100
bus_generic_attach(c2132300,f0000000,c0531de0,c05302a0,c2123900,...) at 
bus_generic_attach+0x19
miibus_attach(c2132300,c20b3054,c080bae4,c0796e08,80000000,...) at 
miibus_attach+0x57
device_attach(c2132300,c2132300,c0796d66,935,c2132300,...) at 
device_attach+0x36f
device_probe_and_attach(c2132300,3,c0c20974,c04e7b0a,c2123900,...) at 
device_probe_and_attach+0x100
bus_generic_attach(c2123900,3,1,c2123380,c2046c00,...) at 
bus_generic_attach+0x19
mii_phy_probe(c2123900,c2046c0c,c0531de0,c05302a0,c052f160,...) at 
mii_phy_probe+0xfa
epic_attach(c2123900,c20d0854,c080bae4,c0796e08,80000000,...) at 
epic_attach+0x7ea
device_attach(c2123900,c2123900,c0796d66,935,c2123900,...) at 
device_attach+0x36f
device_probe_and_attach(c2123900,c2088800,c0c20a94,c048126c,c2123380,...) 
at device_probe_and_attach+0x100
bus_generic_attach(c2123380,c204fda0,1,c0480cb0,c2123380,0,c204fda0) at 
bus_generic_attach+0x19
acpi_pci_attach(c2123380,c20d5854,c080bae4,c0796e08,80000000,...) at 
acpi_pci_attach+0x18c
device_attach(c2123380,c2123380,c0796d66,935,c2123380,...) at 
device_attach+0x36f
device_probe_and_attach(c2123380,c2088c80,c0c20b34,c04832c4,c2088800,...) 
at device_probe_and_attach+0x100
bus_generic_attach(c2088800,c07b5fc2,0,c0c20b24,c204fda0,...) at 
bus_generic_attach+0x19
acpi_pcib_attach(c2088800,c21151b4,0,c0c20b54,2,...) at 
acpi_pcib_attach+0x194
acpi_pcib_acpi_attach(c2088800,c20ac054,c080bae4,c0796e08,80000000,...) 
at acpi_pcib_acpi_attach+0x236
device_attach(c2088800,c2088800,c0796d66,935,c2088800,...) at 
device_attach+0x36f
device_probe_and_attach(c2088800,297,c0c20c54,c0478faa,c2088c80,...) at 
device_probe_and_attach+0x100
bus_generic_attach(c2088c80,294,297,c2112668,294,...) at 
bus_generic_attach+0x19
acpi_attach(c2088c80,c20ad854,c080bae4,c0796e08,80000000,...) at 
acpi_attach+0xb3a
device_attach(c2088c80,c2088c80,c0796d66,935,c2088c80,...) at 
device_attach+0x36f
device_probe_and_attach(c2088c80,c20fa300,c0c20ce8,c07278ae,c20fa300,...) 
at device_probe_and_attach+0x100
bus_generic_attach(c20fa300,a,c077bc2c,0) at bus_generic_attach+0x19
nexus_acpi_attach(c20fa300,c20e6854,c080bae4,c0796e08,80000000,...) at 
nexus_acpi_attach+0x7e
device_attach(c20fa300,c20fa300,c0796d66,935,c20fa300,...) at 
device_attach+0x36f
device_probe_and_attach(c20fa300,c07c0078,c0c20d6c,c072c65c,c085ae54,...) 
at device_probe_and_attach+0x100
root_bus_configure(c085ae54,c0c20d88,c056ada6,0,c1ec00,...) at 
root_bus_configure+0x1b
configure(0,c1ec00,c1ec00,c1e000,c25000,...) at configure+0xc
mi_startup() at mi_startup+0x96
begin() at begin+0x2c