Re: CFT: vr(4)

On Wed, Mar 05, 2008 at 11:20:00AM -0500, Mike Tancsa wrote:
 > At 09:31 PM 3/3/2008, Pyun YongHyeon wrote:
 > 
 > >It seems that I've made mistake in implementing memory mapped
 > >register access. Even if datasheet says no special things for
 > >reloading EEPROM, Rhine family seems to default to io register
 > >access after reloading EEPROM. I guess this would be root cause of
 > >Milan Obuch's issue. It seems that his hardware requires memory
 > >mapped register access but reloading EEPROM disabled it.
 > >ATM I have no clean idea how can I renable memory mapped register
 > >access after EEPROM reloading without hacks so I completely backed
 > >out memory mapped register access and put updated vr(4) to the same
 > >URL. Please try again updated vr(4) and let me know how it goes.
 > 
 > Hi,
 >         I tried both the if_vr.c and if_vr.c.memio version on 
 > RELENG_7 and it seems fine on my hardware.  I also check and 
 > confirmed vlans were still working.  Thanks again for fixing this 
 > driver!  BTW, for the RELENG_6, we implemented a userland work around 
 > to deal with when the nic bounces.
 > 

memio version seems to need more work. I'll commit without memio
function after fixing a regression reported by Phil Oleson.

Thank you.
-- 
Regards,
Pyun YongHyeon