Re: CFT: vr(4)

At 09:31 PM 3/3/2008, Pyun YongHyeon wrote:

>It seems that I've made mistake in implementing memory mapped
>register access. Even if datasheet says no special things for
>reloading EEPROM, Rhine family seems to default to io register
>access after reloading EEPROM. I guess this would be root cause of
>Milan Obuch's issue. It seems that his hardware requires memory
>mapped register access but reloading EEPROM disabled it.
>ATM I have no clean idea how can I renable memory mapped register
>access after EEPROM reloading without hacks so I completely backed
>out memory mapped register access and put updated vr(4) to the same
>URL. Please try again updated vr(4) and let me know how it goes.

Hi,
         I tried both the if_vr.c and if_vr.c.memio version on 
RELENG_7 and it seems fine on my hardware.  I also check and 
confirmed vlans were still working.  Thanks again for fixing this 
driver!  BTW, for the RELENG_6, we implemented a userland work around 
to deal with when the nic bounces.

dmesg is the same for both versions.

vr0: <VIA VT6105M Rhine III 10/100BaseTX> port 0xe100-0xe1ff mem 
0xa0004000-0xa00040ff irq 11 at device 6.0 on pci0
vr0: Quirks: 0x6
vr0: Revision: 0x96
miibus0: <MII bus> on vr0
ukphy0: <Generic IEEE 802.3u media interface> PHY 1 on miibus0
ukphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
vr0: Ethernet address: 00:00:24:c9:34:88
vr0: [ITHREAD]
vr1: <VIA VT6105M Rhine III 10/100BaseTX> port 0xe200-0xe2ff mem 
0xa0004100-0xa00041ff irq 5 at device 7.0 on pci0
vr1: Quirks: 0x6
vr1: Revision: 0x96
miibus1: <MII bus> on vr1
ukphy1: <Generic IEEE 802.3u media interface> PHY 1 on miibus1
ukphy1:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
vr1: Ethernet address: 00:00:24:c9:34:89
vr1: [ITHREAD]
vr2: <VIA VT6105M Rhine III 10/100BaseTX> port 0xe300-0xe3ff mem 
0xa0004200-0xa00042ff irq 9 at device 8.0 on pci0
vr2: Quirks: 0x6
vr2: Revision: 0x96
miibus2: <MII bus> on vr2
ukphy2: <Generic IEEE 802.3u media interface> PHY 1 on miibus2
ukphy2:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
vr2: Ethernet address: 00:00:24:c9:34:8a
vr2: [ITHREAD]
vr3: <VIA VT6105M Rhine III 10/100BaseTX> port 0xe400-0xe4ff mem 
0xa0004300-0xa00043ff irq 12 at device 9.0 on pci0
vr3: Quirks: 0x6
vr3: Revision: 0x96
miibus3: <MII bus> on vr3
ukphy3: <Generic IEEE 802.3u media interface> PHY 1 on miibus3
ukphy3:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
vr3: Ethernet address: 00:00:24:c9:34:8b
vr3: [ITHREAD]


# ifconfig
vr0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
         options=b<RXCSUM,TXCSUM,VLAN_MTU>
         ether 00:00:24:c9:34:88
         inet 192.168.43.171 netmask 0xffffff00 broadcast 192.168.43.255
         media: Ethernet autoselect (100baseTX <full-duplex>)
         status: active
vr1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
         options=b<RXCSUM,TXCSUM,VLAN_MTU>
         ether 00:00:24:c9:34:89
         inet 1.1.1.1 netmask 0xfffffffc broadcast 1.1.1.3
         media: Ethernet autoselect (100baseTX <full-duplex>)
         status: active
vr2: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
         options=b<RXCSUM,TXCSUM,VLAN_MTU>
         ether 00:00:24:c9:34:8a
         inet 192.168.7.171 netmask 0xffffff00 broadcast 192.168.7.255
         media: Ethernet autoselect (100baseTX <full-duplex>)
         status: active
vr3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
         options=b<RXCSUM,TXCSUM,VLAN_MTU>
         ether 00:00:24:c9:34:8b
         media: Ethernet autoselect (100baseTX <full-duplex>)
         status: active
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
         inet 127.0.0.1 netmask 0xff000000
pflog0: flags=141<UP,RUNNING,PROMISC> metric 0 mtu 33204
vr1.50: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
         ether 00:00:24:c9:34:89
         inet 192.168.50.171 netmask 0xffffff00 broadcast 192.168.50.255
         media: Ethernet autoselect (100baseTX <full-duplex>)
         status: active
         vlan: 50 parent interface: vr1


Here is a tcpdump from vr1 when its in trunk mode and the other side 
is doing a ping -s 1500 192.168.50.171

# tcpdump -nei vr1
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on vr1, link-type EN10MB (Ethernet), capture size 68 bytes
11:14:23.286178 00:07:85:83:f7:ab > 01:00:0c:cc:cc:cd, ethertype 
802.1Q (0x8100), length 68: vlan 50, p 7, LLC, dsap SNAP (0xaa) 
Individual, ssap SNAP (0xaa) Command, ctrl 0x03: oui Cisco 
(0x00000c), pid Unknown (0x010b): Unnumbered, ui, Flags [Command], length 50
11:14:23.451402 00:0e:2e:6b:c4:c6 > 00:00:24:c9:34:89, ethertype 
802.1Q (0x8100), length 1518: vlan 50, p 0, ethertype IPv4, 
192.168.50.1 > 192.168.50.171: ICMP echo request, id 50132, seq 21, length 1480
11:14:23.451450 00:0e:2e:6b:c4:c6 > 00:00:24:c9:34:89, ethertype 
802.1Q (0x8100), length 66: vlan 50, p 0, ethertype IPv4, 
192.168.50.1 > 192.168.50.171: icmp
11:14:23.451527 00:00:24:c9:34:89 > 00:0e:2e:6b:c4:c6, ethertype 
802.1Q (0x8100), length 1518: vlan 50, p 0, ethertype IPv4, 
192.168.50.171 > 192.168.50.1: ICMP echo reply, id 50132, seq 21, length 1480
11:14:23.451543 00:00:24:c9:34:89 > 00:0e:2e:6b:c4:c6, ethertype 
802.1Q (0x8100), length 66: vlan 50, p 0, ethertype IPv4, 
192.168.50.171 > 192.168.50.1: icmp
11:14:23.807447 00:07:85:83:f7:ab > 01:00:0c:cc:cc:cd, 802.3, length 
64: LLC, dsap SNAP (0xaa) Individual, ssap SNAP (0xaa) Command, ctrl 
0x03: oui Cisco (0x00000c), pid Unknown (0x010b): Unnumbered, ui, 
Flags [Command], length 50
11:14:23.808887 00:07:85:83:f7:ab > 01:80:c2:00:00:00, 802.3, length 
60: LLC, dsap STP (0x42) Individual, ssap STP (0x42) Command, ctrl 
0x03: STP 802.1d, Config, Flags [none], bridge-id 
8000.00:07:85:83:f7:80.803c, length 43
11:14:24.452402 00:0e:2e:6b:c4:c6 > 00:00:24:c9:34:89, ethertype 
802.1Q (0x8100), length 1518: vlan 50, p 0, ethertype IPv4, 
192.168.50.1 > 192.168.50.171: ICMP echo request, id 50132, seq 22, length 1480
11:14:24.452450 00:0e:2e:6b:c4:c6 > 00:00:24:c9:34:89, ethertype 
802.1Q (0x8100), length 66: vlan 50, p 0, ethertype IPv4, 
192.168.50.1 > 192.168.50.171: icmp
11:14:24.452525 00:00:24:c9:34:89 > 00:0e:2e:6b:c4:c6, ethertype 
802.1Q (0x8100), length 1518: vlan 50, p 0, ethertype IPv4, 
192.168.50.171 > 192.168.50.1: ICMP echo reply, id 50132, seq 22, length 1480
11:14:24.452540 00:00:24:c9:34:89 > 00:0e:2e:6b:c4:c6, ethertype 
802.1Q (0x8100), length 66: vlan 50, p 0, ethertype IPv4, 
192.168.50.171 > 192.168.50.1: icmp