Re: shared lock instead of exclusive in set_rootvnode

From: Roman Divacky <rdivacky_at_freebsd.org>
Date: Sun, 30 Mar 2008 23:49:47 +0200
On Tue, Mar 04, 2008 at 01:15:42PM +0200, Kostik Belousov wrote:
> On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote:
> > hi
> > 
> > in set_rootvnode() there is 
> > 
> > p->p_fd->fd_cdir = rootvnode;
> > p->p_fd->fd_rdir = rootvnode;
> > 
> > protected just by FILEDESC_SLOCK(), I dont think this is correct
> > although it might be benign as this is used only during boot.
> > 
> > still, if it's not correct it should be fixed
> > 
> > comments?
> 
> Seems right. Did you boot with patched kernel ?

I've been running with this patch for a month... is it time to commit
this?
Received on Sun Mar 30 2008 - 19:50:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:29 UTC