Re: [patch] zfs livelock and thread priorities

On Sat, Apr 25, 2009 at 01:49:33PM -0400, Ben Kelly wrote:
  
  On Apr 24, 2009, at 11:59 PM, Artem Belevich wrote:
  
  > Ah! Indeed.
  >
  >> va_list va;
  >> va_start(ap, fmt);
  >> va_copy(va, ap);
  >> vsnprintf(p2->p_comm, sizeof(p2->p_comm), fmt, va);
  >> vsnprintf(td->td_name, sizeof(td->td_name), fmt, ap);
  >
  > We also need va_end(va) to clear up after va_copy();
  
  I've updated the patch to use va_copy().  Unfortunately I don't have  
  an AMD64 machine to test on at the moment.  However, I did look at  
  other places in the kernel where va_copy() is used so I am hopeful I  
  got it right.
  
  Thanks again for the help!
  
  - Ben
  
I have the patch running on a amd64 desktop at home,
so far so good and I'll run some portupgrades overnight.
Assuming no huge problems with that, I have one or more
systems at work I can try it with as well, as I have time.