Re: RFC: new utility, kmodpatch

On Saturday 03 January 2009 19:47:29 dvg_lab wrote:
> Hi,
>
> I mentioned this utility a couple of months ago, and it's now working
>
> > so i would like to receive feedback on whether this is good to have
> > as part of the system, or just keep it as a port (which is what
> > i plan to do by default).
> >
> > In a nutshell, the kmodpatch utility can print or alter the content
> > of device/quirk tables in kernel modules (I think Linux has some
> > similar tool, though i don't remember the name -- or perhaps it is
> > a feature of insmod ?).
>
> Can't make it on CURRENT (31.12.2008) amd64
>
> dvg-nb# make
> cc -O2 -pipe  -O1 -Wall -Werror -Wunused -g -I/usr/local/include
> -L/usr/local/lib -lkvm  kmodpatch.c  -o kmodpatch
> cc1: warnings being treated as errors
> kmodpatch.c: In function 'dump':
> kmodpatch.c:234: warning: format '%d' expects type 'int', but argument 3
> has type 'size_t'

change %d to %zu

> kmodpatch.c:291: warning: format '%016llx' expects type 'long long unsigned
> int', but argument 3 has type 'uint64_t'

change %016llx to %016jx and cast argument three to uintmax_t

> kmodpatch.c: In function 'do_rw':
> kmodpatch.c:535: warning: format '%d' expects type 'int', but argument 5
> has type 'size_t'

See above %zu

> *** Error code 1
>
> Stop in /home/dvg/downloads/kmodpatch.
>
> WBR,
> Vyacheslav Druzhinin

-- 
/"\  Best regards,                      | mlaier_at_freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier_at_EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News