> Xin, good day. > > Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: > > The attached patch should fix this, any objections? > > Yes, you missed negation operator in the copyin check. The issue > was already fixed by hrs_at_ two hours ago: > http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 sorry to barge in, but: if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) is not clear, if ((options & ~GIF_FULLOPTS) == 0) seems to be less offuscated or I'm missing something? danny > -- > Eygene > _ ___ _.--. # > \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard > / ' ` , __.--' # to read the on-line manual > )/' _/ \ `-_, / # while single-stepping the kernel. > `-'" `"\_ ,_.-;_.-\_ ', fsc/as # > _.-'_./ {_.' ; / # -- FreeBSD Developers handbook > {_.-``-' {_/ # > _______________________________________________ > freebsd-current_at_freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org" >Received on Tue Jun 09 2009 - 05:45:58 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:49 UTC