"Bjoern A. Zeeb" <bzeeb-lists_at_lists.zabbadoz.net> wrote in <20090609074144.O22887_at_maildrop.int.zabbadoz.net>: bz> On Tue, 9 Jun 2009, Xin LI wrote: bz> bz> > Danny Braniss wrote: bz> >>> Xin, good day. bz> >>> bz> >>> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: bz> >>>> The attached patch should fix this, any objections? bz> >>> Yes, you missed negation operator in the copyin check. The issue bz> >>> was already fixed by hrs_at_ two hours ago: bz> >>> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 bz> >> sorry to barge in, but: bz> >> if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) bz> >> is not clear, bz> >> if ((options & ~GIF_FULLOPTS) == 0) bz> >> seems to be less offuscated or I'm missing something? bz> > bz> > Yes this looks like the usually used idiom (perhaps more efficient bz> > anyway)... I just kept the style consistent with the old code. bz> > Hiroki-san, could you have a look at this and consider if we should bz> > use bz> > this idiom? bz> bz> Also see the mail I had sent in reply to the commit message yesterday. Sorry, I overlooked some of the messages I received. Yes, the logic was reversed and fixed now, but your patch including style fix looks better to me. I will commit it. Thank you for your review! -- Hiroki
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:49 UTC