Re: CFT: fxp(4)

On Mon, Jun 15, 2009 at 09:08:46AM +0100, Bruce Simpson wrote:
> Pyun YongHyeon wrote:
> >Please test the patch in the following URL if you have fxp(4)
> >hardwares. The patch contains various accumulated fixes for 
> >multicast handling, bus_dma fixes, more sane initialization
> >and enhanced lockup detection for buggy controllers.
> 
> This is just a note to say that I *have* observed problems with 
> multicast setup in fxp(4) -- it seems to need setting up of the 
> link-layer hash filter for a group to transmit as well as receive.
> 

I couldn't see this limitation in datasheet. So it could be a
bug in stock fxp(4).

> This isn't OK, NICs should be able to transmit w/o receive setup, and 
> may break normal use-cases (esp. IPv6), I posted to freebsd-net_at_ about 
> this over the past 12 months, but did not have time to reproduce or 
> isolate the issue. So a fix is very, very welcome. Thanks for working on 
> this.

So does that patch fixed the issue? I'm not familiar with
multicasting but I did my best to make fxp(4) work on multicasting
environments. fxp(4) hardwares do not allow multicast hash filter
programming when device is not in idle state. So stock fxp(4)
used to rely on Tx completion interrupt to program multicast
filters. I think that is error-prone/complex and fxp(4) can drop
multicat frames until its filter is fully reprogrammed.

> 
> I have an fxp(4) but it's in my home server RELENG_7 box... any plans to 
> backport?
> 

Yeah, if the patch works.

> thanks,
> BMS