[PATCH]: if (cond); foo() in firewire

From: Roman Divacky <rdivacky_at_freebsd.org>
Date: Sun, 21 Jun 2009 10:20:22 +0200
hi

is this patch correct? may I commit it?

Index: ../../../dev/firewire/fwdev.c
===================================================================
--- ../../../dev/firewire/fwdev.c       (revision 194573)
+++ ../../../dev/firewire/fwdev.c       (working copy)
_at__at_ -443,7 +443,7 _at__at_
        xfer->send.pay_len = uio->uio_resid;
        if (uio->uio_resid > 0) {
                if ((err = uiomove((caddr_t)&xfer->send.payload[0],
-                   uio->uio_resid, uio)));
+                   uio->uio_resid, uio)))
                        goto out;
        }
 

another bug found by the "useless warnings in clang" ;)

roman

Received on Sun Jun 21 2009 - 06:20:37 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:50 UTC