Re: [PATCH]: if (cond); foo() in firewire

On Sun, 21 Jun 2009 10:20:22 +0200
Roman Divacky <rdivacky_at_freebsd.org> wrote:

> hi
> 
> is this patch correct? may I commit it?
> 
> Index: ../../../dev/firewire/fwdev.c
> ===================================================================
> --- ../../../dev/firewire/fwdev.c       (revision 194573)
> +++ ../../../dev/firewire/fwdev.c       (working copy)
> _at__at_ -443,7 +443,7 _at__at_
>         xfer->send.pay_len = uio->uio_resid;
>         if (uio->uio_resid > 0) {
>                 if ((err = uiomove((caddr_t)&xfer->send.payload[0],
> -                   uio->uio_resid, uio)));
> +                   uio->uio_resid, uio)))
>                         goto out;
>         }
>  
> 
> another bug found by the "useless warnings in clang" ;)
> 

Certainly looks like it should be corrected.  I'd say go ahead
and commit it in my guise as a former src-committer :)

---
Gary Jennejohn