Re: kernel compile fails without AH_SUPPORT_AR5416

From: Bruce Simpson <bms_at_incunabulum.net>
Date: Fri, 01 May 2009 17:51:26 +0100
Sam Leffler wrote:
> ...
>>>> the "ath_hal" device.
>> Do not modify ah_desc.h like you've done.  Add this to conf/options
>>
>> ATH_HAL   opt_ah.h
>>
>> and use that to enable AH_SUPPORT_AR5416.
>>
> To clarify the first comment: you've made it impossible to build code 
> w/o the extended format descriptor; this is what I find unacceptable.

Ah, of course, duh -- I forgot about the CaPiTalIzAtion of the device 
name gets pulled into config(5) with the 'device' keyword. Thanks for 
the reminder...

This is a much cleaner fix for the issue than forcing the option to be 
set on always. It looks like HEAD has this issue too and this can go 
right in there.

Are we happy with AH_SUPPORT_AR5416 being enabled in 7.x GENERIC?
The 'out of box' config hasn't been broken by the change and this is 
identical to to the situation in HEAD as far as I can see.

thanks,
BMS
Received on Fri May 01 2009 - 14:51:31 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:47 UTC