Re: svn commit: r197698 - head/etc/rc.d

From: Anonymous <swell.k_at_gmail.com>
Date: Fri, 23 Oct 2009 13:21:28 +0400
Anonymous <swell.k_at_gmail.com> writes:

> Hiroki Sato <hrs_at_FreeBSD.org> writes:
>
>> Modified: head/etc/rc.d/netoptions
> [...]
>>  
>>  	if checkyesno tcp_extensions; then
>> +		${SYSCTL_W} net.inet.tcp.rfc1323=1 >/dev/null
>> +	else
>>  		netoptions_init
>> -		echo -n ' rfc1323 extensions=NO'
>> +		echo -n ' rfc1323 extensions=${tcp_extensions}'
>                                              ^^^^^^^^^^^^^^^^^
> Here.
>
>>  		${SYSCTL_W} net.inet.tcp.rfc1323=0 >/dev/null
>>  	fi
>>  
>> -	if ! checkyesno tcp_keepalive; then
>> +	if checkyesno tcp_keepalive; then
>> +		${SYSCTL_W} net.inet.tcp.always_keepalive=1 >/dev/null
>> +	else
>>  		netoptions_init
>> -		echo -n ' TCP keepalive=NO'
>> +		echo -n ' TCP keepalive=${tcp_keepalive}'
>                                         ^^^^^^^^^^^^^^^^
> Here.
>
>>  		${SYSCTL_W} net.inet.tcp.always_keepalive=0 >/dev/null
>>  	fi
>>  
>>  	if checkyesno tcp_drop_synfin; then
>>  		netoptions_init
>> -		echo -n ' drop SYN+FIN packets=YES'
>> +		echo -n ' drop SYN+FIN packets=${tcp_drop_synfin}'
>                                                ^^^^^^^^^^^^^^^^^^
> And here. These are *single* quotes, no parameter expansion can occur.
> I keep getting following in `dmesg -a'
>
>     Additional TCP/IP options:
>      drop SYN+FIN packets=${tcp_drop_synfin}
>     .

Am I the only one who has above issue with tcp_drop_synfin=YES in
rc.conf? I'm talking about unexpanded ${tcp_drop_synfin}.
Received on Fri Oct 23 2009 - 07:21:36 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:57 UTC