Re: Does "makeoptions WITH_CTF=yes" actually work?

On Fri, Apr 16, 2010 at 03:51:40PM +0200, Alexander Leidinger wrote:
> Quoting Navdeep Parhar <nparhar_at_gmail.com> (from Wed, 14 Apr 2010
> 11:35:40 -0700):
>
> >Have you or anyone else ever used buildkernel successfully with
> >"makeoptions WITH_CTF=yes" in the conf file?  Something as simple as
> >this does not work for me:
>
> Copy&paste patch, tabs probbly mangled:
> ---snip---
> Index: Makefile.inc1
> ===================================================================
> --- Makefile.inc1       (revision 206700)
> +++ Makefile.inc1       (working copy)
> _at__at_ -314,7 +314,7 _at__at_
>  .endif
>
>  # kernel stage
> -KMAKEENV=      ${WMAKEENV}
> +KMAKEENV=      ${WMAKEENV:NNO_CTF=1}
>  KMAKE=         ${KMAKEENV} ${MAKE} KERNEL=${INSTKERNNAME}
>
>  #
> _at__at_ -780,7 +780,7 _at__at_
>         _at_echo "--------------------------------------------------------------"
>         cd ${KRNLOBJDIR}/${_kernel}; \
>             MAKESRCPATH=${KERNSRCDIR}/dev/aic7xxx/aicasm \
> -           ${MAKE} SSP_CFLAGS= -DNO_CPU_CFLAGS -DNO_CTF \
> +           ${MAKE} SSP_CFLAGS= -DNO_CPU_CFLAGS \
>             -f ${KERNSRCDIR}/dev/aic7xxx/aicasm/Makefile
>  # XXX - Gratuitously builds aicasm in the ``makeoptions NO_MODULES'' case.
>  .if !defined(MODULES_WITH_WORLD) && !defined(NO_MODULES) &&
> exists(${KERNSRCDIR}/modules)
> ---snip---
>
> This lets the buildkernel generate ctf info in the object files (the
> build is not finished yet, so I still have to verify that the final
> kernel contains them too, but I do not see a reason ATM why this
> should not be the case).

Your patch works for me, thanks.  There is just one more problem with the CTF
generation that needs to be fixed:

http://lists.freebsd.org/pipermail/freebsd-hackers/2009-April/028244.html

While you're here can you take a look at the patch in that email too?

Regards,
Navdeep