Re: [CFT] BSDL iconv in base system

Jilles Tjoelker <jilles_at_stack.nl> writes:

> On Wed, Jun 16, 2010 at 10:04:16PM +0300, Jaakko Heinonen wrote:
>> On 2010-06-15, Gabor Kovesdan wrote:
>> > - The iconv.h header files is supposed to be compatible with the GNU 
>> > version, i.e. sources should build with base iconv.h and GNU libiconv. 
>> > I've just did a very quick test and it seems ports can safely link to 
>> > GNU libiconv, there's no conflict.
>
>> > The rather big patch (42,5M) is available here: 
>> > http://www.kovesdan.org/patches/iconv_base_integrate.diff
>
>> iconv(3) prototype doesn't conform to POSIX.1-2008. Is it a
>> well-considered decision?
>
> I think the difference from POSIX.1-2008 is pretty common and may
> therefore cause less compilation problems. NetBSD's Citrus iconv and GNU
> iconv have the extra 'const', and so does the default Solaris iconv

GNU iconv doesn't use `const' by default. Our port adds it explicitly.

    CONFIGURE_ENV= gl_cv_cc_visibility="no" \
                   am_cv_func_iconv="yes" \
                   am_cv_proto_iconv_arg1="const"

For example, devel/git refers to `const' using OLD_ICONV macro.

BTW, iconv() on DragonFlyBSD doesn't seem to have `const', too.

> (Solaris has a separate iconv for standards-conforming applications with
> the POSIX prototype.)