Re: [dtrace] syscall provider naming convention.

From: Andriy Gapon <avg_at_freebsd.org>
Date: Fri, 24 Dec 2010 22:00:08 +0200
on 24/12/2010 04:02 Artem Belevich said the following:
>> I have one comment though.  I am not sure about renaming syscall.ko to
>> syscall_freebsd.ko.
> 
> You mean systrace_freebsd.ko.

Yes, thanks.

> I've renamed it for consistency with other systrace provider variants.
> I can change it back.

I think that I would prefer this.
If only for POLA reasons.

>> Perhaps we could keep the old name?  Or add a new module
>> under that name that would load native syscall module and all emulation syscall
>> modules (if any)?
> 
> I'm not sure that creating an umbrella 'systrace' module is worth it.
> "kldload /boot/kernel/systrace*" should do that just fine. The reason
> dtrace exists is that there are number of modules with dtrace
> providers that are not easily distinguishable by their name.

I agree.

I am going on vacation and I don't want to risk, so it looks like I will be able
to commit your patch after the holidays.  Unless someone else beats me to it.

-- 
Andriy Gapon
Received on Fri Dec 24 2010 - 19:00:16 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:10 UTC