Re: [CFT] BSDL iconv in base system

(my previous mail didn't appear in the archives)

Anonymous <swell.k_at_gmail.com> writes:

> Gabor Kovesdan <gabor_at_FreeBSD.org> writes:
>> Here's the new patch, which is supposed to fix the following issues:
>> - Fixed build on amd64 and fixed cross-compiling
>> - Fixed hang when linked to libthr
>> - Fixed iconv() prototype as per POSIX
>> - More GNU compatibility: "" or "char" means the current local
>> encoding in use
>>
>> http://kovesdan.org/patches/iconv_current.diff
>
> BTW, I think there is regression in iconv(1). It wasn't there in iconv_base_integrate2.diff.
>
>   (gdb) r
>   Starting program: /usr/bin/iconv
>   During symbol reading, DW_AT_name missing from DW_TAG_base_type.
>   During symbol reading, cannot get low and high bounds for subprogram DIE at 11006.
>   During symbol reading, DW_AT_name missing from DW_TAG_base_type.
>
>   Program received signal SIGSEGV, Segmentation fault.
>   0x0000000000401281 in main (argc=
>   During symbol reading, incomplete CFI data; unspecified registers (e.g., rax) at 0x401180.
>   0, argv=0x7ffffffefb98) at /a/blah/usr.bin/iconv/iconv.c:198
>   198             if ((strcmp(opt_f, "") == 0) && (strcmp(opt_t, "") == 0))
>   (gdb) bt f
>   #0  0x0000000000401281 in main (argc=0, argv=0x7ffffffefb98) at /a/blah/usr.bin/iconv/iconv.c:198
>           fp = <value optimized out>
>           opt_f = 0x0
>           opt_t = 0x0
>           ch = <value optimized out>
>           i = <value optimized out>
>           opt_c = false
>           opt_s = false
>   (gdb) p *argv
>   $1 = 0x0

It works if I specify both `-t' and `-f'. And crashes when none
specified or only one of them.