Re: Call for Test and Review: bwn(4) - another Broadcom Wireless driver

On Sun, Apr 25, 2010 at 10:42:16PM +0200, Gustau P?rez wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> >> I've been testing the driver for a few time with AMD64/CURRENT. A
> >> few time ago I started to see messages like :
> >>
> >> bwn0: unsupported rate 0
> >>
> >> I've checked the code and I found it seems to fail when trying to
> >> check the TX rate at if_bw.c:9561 (in bwn_ieeerate2hwrate
> >> routine the rate parameter is 0). I checked where bwn_ieeerate2hwrate
> >> is called, to see how 'rate' is calculated. This is where I got lost :(
> >>
> >> My AP is FreeBSD 8.0 box with an atheros card. My hostapd works
> >> with both WPA2-PSK and WPA2-EAP (although
> >> I thinks this is not the problem) but with default values for rates
> >> and friends. I then forced my hostapd to use only a subset of transmit
> >> rates (with supported_rates and basic_rates) with no luck.
> >>
> >> My laptop is a DELL D630 with a BCM4310 UART adapter.
> >>
> >> Any need info will be provided and any help will be appreciated.
> >
> > First I think we need to know that where rate == 0 comes from.  Rate
> > information on TX could be got from the following points:
> >
> >     tp->mgmtrate
> >     tp->mcastrate
> >     tp->ucastrate
> >     ni->ni_txrate
> >
>   Added some device_printf to test those values. This is what I got :
> 
> bwn0: tp->mgmtrate : 2
> bwn0: tp->mcastrate : 2
> bwn0: tp->ucastrate : 255
> bwn0: ni->ni_txrate : 0
> 
>    I didn't have time to follow the code to find out why it has a 0
> value. If you need
> more info let me know.

Hello Gustau, I'm so sorry for belated response that I had no time to
read and work email and wireless stuffs.

Could you please test this symptom with attached patch?  It looks in
CURRENT it missed to initialize a ratectl when it associates with AP.

regards,
Weongyo Jeong