Re: RFT: if_ath HAL refactoring

On Saturday, September 18, 2010 12:09:21 pm Adrian Chadd wrote:
> Hi all,
> 
> I've uploaded a snapshot of the if_ath HAL which i've been working on.
> I've been refactoring out various bits of the AR5416 HAL into
> something that resembles the ath9k hardware MAC/PHY operations to make
> it easier to port further ath9k updates over. It also includes the
> AR9100 support (but it's missing a couple bits of glue needed to use
> it outside of my GIT tree.) Finally, it includes the probe/attach
> operations for the AR2427, but I haven't at all tested it yet (and
> i've explained why it isn't working in a previous email.)
> 
> It's available for download at http://people.freebsd.org/~adrian/ath/
> . There's a diff against src/sys/files/conf and a tarball that just
> replaces the ath device/module directory.
> 
> Note you'll need to add "device if_ath_pci" to your kernel
> configuration file as the PCI bus glue is now not built by default in
> a static kernel in this HAL. (It's included in the module Makefile by
> default.) This was done to allow multiple backend bus types - now
> being PCI and "AHB" for the AR9100 SoC.

Why not include this iff both 'device ath' and 'device pci' are included?  
That is what is normally done for bus-specific attachments.

-- 
John Baldwin