Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS

On Thu Apr  7 11, Garrett Cooper wrote:
> On Thu, Apr 7, 2011 at 2:22 PM, Alexander Best <arundel_at_freebsd.org> wrote:
> > On Thu Apr  7 11, Garrett Cooper wrote:
> >> On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper <yanegomi_at_gmail.com> wrote:
> >> > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best <arundel_at_freebsd.org> wrote:
> >> >> hi there,
> >> >>
> >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let
> >> >> tinderbox fail, if any new kernel code was committed with (a) broken include
> >> >> dir(s).
> >> >>
> >> >> i ran a test via
> >> >>
> >> >> make toolchains
> >> >> make MAKE_JUST_KERNELS=yes tinderbox
> >> >>
> >> >> and nothing seemed to go wrong with the extra warning enabled. i even found a
> >> >> missing include dir, which should be fixed by the attached patch.
> >> >>
> >> >> opinions?
> >> >>
> >> >> so far i've only tested this with gcc. i think someone on #freebsd-clang told
> >> >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons).
> >> >
> >> >    make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf
> >> > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these
> >> > files, but it doesn't currently)?
> >
> > otaku% make -f /etc/src.conf -VMODULES_OVERRIDE
> > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock
> > otaku% make -f /etc/make.conf -VMODULES_OVERRIDE
> > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock
> >
> > ...however i checked and tinderbox *does* ignore src.conf and make.conf. the
> > _.* log files show that modules were being build which are not returned by
> > the commands above.
> >
> > i think having this flag would be very useful, because it would force people to
> > make sure their include dirs are correct.
> >
> >>
> >> Sorry. Second invocation should have been make.conf, not src.conf.
> 
> Ok then. I stand corrected for not having tested out my claim beforehand.
> 
> Yes, I agree that adding this flag in the default set is a good idea.

cool. so now we need somebody to make the commit. ;)

> 
> Thanks,
> -Garrett

-- 
a13x