On 12/23/11 16:24, Jeremy Chadwick wrote: > On Fri, Dec 23, 2011 at 10:00:05AM -0500, John Baldwin wrote: >> On Thursday, December 22, 2011 6:58:46 pm Jeremy Chadwick wrote: >>> On Fri, Dec 23, 2011 at 12:44:14AM +0100, O. Hartmann wrote: >>>> On 12/21/11 19:41, Alexander Leidinger wrote: >>>>> Hi, >>>>> >>>>> while the discussion continued here, some work started at some other >> place. Now... in case someone here is willing to help instead of talking, feel >> free to go to http://wiki.freebsd.org/BenchmarkAdvice and have a look what can >> be improved. The page is far from perfect and needs some additional people >> which are willing to improve it. >>>>> >>>>> This is only part of the problem. A tuning page in the wiki - which >> could be referenced from the benchmark page - would be great too. Any >> volunteers? A first step would be to take he tuning-man-page and wikify it. >> Other tuning sources are welcome too. >>>>> >>>>> Every FreeBSD dev with a wiki account can hand out write access to the >> wiki. The benchmark page gives contributor-access. If someone wants write >> access create a FirstnameLastname account and ask here for contributor-access. >>>>> >>>>> Don't worry if you think your english is not good enough, even some one- >> word notes can help (and _my_ english got already corrected by other people on >> the benchmark page). >>>>> >>>>> Bye, >>>>> Alexander. >>>>> >>>>> >>>>> >>>>> >>>> >>>> Nice to see movement ;-) >>>> >>>> But there seems something unclear: >>>> >>>> man make.conf(5) says, that MALLOC_PRODUCTION is a knob set in >>>> /etc/make.conf. >>>> The WiJi says, MALLOC_PRODUCTION is to be set in /etc/src.conf. >>>> >>>> What's right and what's wrong now? >>> >>> I can say with certainty that this value belongs in /etc/make.conf >>> (on RELENG_8 and earlier at least). >>> >>> src/share/mk/bsd.own.mk has no framework for MK_MALLOC_PRODUCTION, >>> so, this is definitely a make.conf variable. >> >> Eh, normal make variables can go in src.conf as well. They do not have >> to be listed in bsd.own.mk. World builds include /etc/src.conf whereas >> every make invocation includes /etc/make.conf via sys.mk. The only reason >> to use /etc/src.conf is to have a place to put variables only affect >> make buildworld / buildkernel but do not affect other make invocations. > > I was always under the impression src.conf(5) variables had to be > manually added to bsd.own.mk and similar bits (e.g. > src/tools/build/options/WITH_xxx which is what's used to create the > src.conf(5) man page), but upon your comment and manual investigation on > my part, I found you're indeed right. Taken from bsd.own.mk: > > 107 .if !defined(_WITHOUT_SRCCONF) > 108 SRCCONF?= /etc/src.conf > 109 .if exists(${SRCCONF}) > 110 .include "${SRCCONF}" > 111 .endif > 112 .endif > > As long as third-party software doesn't depend on MALLOC_PRODUCTION for > something (I don't know why something would, but who knows; maybe > there's a third-party malloc implementation which might?), then putting > it in src.conf would be fine (src/lib/libc/stdlib files reference it). > Then the manpage should reflect this. man src.conf does not show up MALLOC_PRODUCTIOn, but man make.conf does. If the latter is right, then it should be worth mentioned that make.conf is incorporating src.conf. Just a suggestion. Regards, Oliver
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:22 UTC