Re: GCC debug flags cleanup

On Thu, Dec 22, 2011 at 6:52 AM, Erik Cederstrand <erik_at_cederstrand.dk> wrote:
> Hi,
>
> I've created a patch that cleans up FreeBSD Makefiles that unconditionally set the -g flag for GCC. The motivation for this is that it should be possible to add or remove this flag globally via e.g. CFLAGS (it's part of my quest to produce deterministic builds).
>
> I'm not very familiar with GCC or the build infrastructure, so I'd be grateful if someone would review it and possibly commit.
>
> http://dev.affect-it.dk/gcc_debug_flags.diff

Generally include your patches inline, it makes reviewing them easier.

Index: sys/amd64/conf/GENERIC
===================================================================
--- sys/amd64/conf/GENERIC  (revision 228312)
+++ sys/amd64/conf/GENERIC  (working copy)
_at__at_ -21,7 +21,7 _at__at_
...
-makeoptions    DEBUG=-g        # Build kernel with gdb(1) debug symbols

...

This is intentionally left in the config files. This is where the
.symbols file comes from in /boot/kernel/.



-- 
Eitan Adler